Skip to content

upgrade to @mattermost/commonmark@0.31.2-0#8722

Merged
enahum merged 1 commit intomainfrom
commonmark@0.31.2-0
Apr 4, 2025
Merged

upgrade to @mattermost/commonmark@0.31.2-0#8722
enahum merged 1 commit intomainfrom
commonmark@0.31.2-0

Conversation

@lieut-data
Copy link
Copy Markdown
Member

@lieut-data lieut-data commented Mar 25, 2025

Summary

Updates the mobile app with the latest (forked) commonmark dependency from mattermost/commonmark.js#22. (Note the commit is temporary, to be replaced with a tagged version once merged.)

Ticket Link

Fixes: https://mattermost.atlassian.net/browse/MM-63537

Checklist

  • [ ] Added or updated unit tests (required for all new features)
  • [ ] Has UI changes
  • [ ] Includes text changes and localization file updates
  • [ ] Have tested against the 5 core themes to ensure consistency between them.
  • Have run E2E tests by adding label E2E iOS tests for PR.

Device Information

This PR was tested on: iOS Simulator (iPhone 16 Pro, iOS 18.2)

Screenshots

N/A

Release Note

Upgrade forked commonmark to 0.31.2-0

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 25, 2025 •
edited
Loading

Coverage Comparison Report

Generated on March 31, 2025 at 16:17:41 UTC

+-----------------+------------+------------+-----------+
| Metric          | Main       | This PR    | Diff      |
+-----------------+------------+------------+-----------+
| Lines           |     85.23% |     85.23% |     0.00% |
| Statements      |     85.12% |     85.12% |     0.00% |
| Branches        |     70.86% |     70.85% |    -0.01% |
| Functions       |     83.35% |     83.35% |     0.00% |
+-----------------+------------+------------+-----------+
| Total           |     81.14% |     81.13% |    -0.01% |
+-----------------+------------+------------+-----------+

@lieut-data lieut-data mentioned this pull request Mar 25, 2025
Merged
enahum
enahum reviewed Mar 26, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@enahum enahum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, do we have an ETA when it will be published on npm?

@lieut-data lieut-data force-pushed the commonmark@0.31.2-0 branch from 95d29e6 to 71bf6fd Compare March 31, 2025 16:11
@lieut-data lieut-data changed the title temp: point at in-progress PR for updated commonmark upgrade to @mattermost/commonmark@0.31.2-0 Mar 31, 2025
@lieut-data lieut-data marked this pull request as ready for review March 31, 2025 16:12
@lieut-data lieut-data requested a review from hmhealey March 31, 2025 16:12
@lieut-data
Copy link
Copy Markdown
Member Author

lieut-data commented Apr 4, 2025

This is great, do we have an ETA when it will be published on npm?

@enahum, should be published now, with this PR updated to reflect same.

@enahum
Copy link
Copy Markdown
Contributor

enahum commented Apr 4, 2025

Thanks!

@enahum enahum merged commit 250732d into main Apr 4, 2025
42 of 45 checks passed
@enahum enahum deleted the commonmark@0.31.2-0 branch April 4, 2025 16:42
@amyblais amyblais added this to the v2.28.0 milestone Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hmhealey hmhealey hmhealey approved these changes

@enahum enahum enahum approved these changes

Assignees

No one assigned

Labels

release-note

Projects

None yet

Milestone

v2.28.0

Development

Successfully merging this pull request may close these issues.

5 participants

@lieut-data @enahum @hmhealey @amyblais @mm-cloud-bot